Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Should libedit be preferred to libreadline?

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org, "Jim C(dot) Nasby" <jnasby(at)pervasive(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>, Seneca Cunningham <scunning(at)ca(dot)afilias(dot)info>
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Date: 2005-12-02 03:27:32
Message-ID: 200512020327.jB23RWO00507@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patchespgsql-ports
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > 	--with-preference-bsd-libedit    prefer libedit over readline
> 
> Can't it just be --with-libedit?  That seems awfully verbose,
> particularly seeing that configure doesn't handle switch abbreviation.

The problem is that we need a clear way to say we don't want any line
editing.  Right now we do it with --without-readline.  Also, we already
test for libedit if we don't find readline.  Would we stop doing that? 
And if we do that, do we tell them they have to say --without-readline
too?  And if we don't, how do we handle it?  I am just confused how to
clean this up without making thing worse.  I am looking for ideas.

I guess my point is do we enable looking for readline and libedit by
default, and if we do how do we specify with to test for first, and how
do we specify we want no line editing functionaliy?

> The patch looks OK offhand, though I didn't try to test it.

I tested it and it does look for libedit first when defined, and matches
the patch posted by the AIX user, except it is a configure option.

Oh, one good thing is that the new configure 2.59 we are using throws an
error now for invalid user-supplied configure options, rather than
silently ignoring it like it used to.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-ports by date

Next:From: Tom LaneDate: 2005-12-02 03:43:19
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Tom LaneDate: 2005-12-02 03:14:12
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?

pgsql-hackers by date

Next:From: Neil ConwayDate: 2005-12-02 03:37:26
Subject: Re: generalizing the planner knobs
Previous:From: Pollard, MikeDate: 2005-12-02 03:21:23
Subject: Re: generalizing the planner knobs

pgsql-patches by date

Next:From: Tom LaneDate: 2005-12-02 03:43:19
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?
Previous:From: Tom LaneDate: 2005-12-02 03:14:12
Subject: Re: [HACKERS] Should libedit be preferred to libreadline?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group