Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Formatting patch for psql

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Formatting patch for psql
Date: 2005-11-24 20:11:46
Message-ID: 20051124201146.GB29774@svana.org (view raw or flat)
Thread:
Lists: pgsql-patches
On Thu, Nov 24, 2005 at 03:45:12PM +0100, Peter Eisentraut wrote:
> Shouldn't you use PQmblen() to determine whether an encoding is 
> single-byte, rather than having an enumerated list?

Actually, thinking about it the answer is no. The code is relying on
the fact that it's a charset that has ASCII as a subset. Unless someone
can say that every single-byte encoding we support has an ASCII subset
(EBCDIC being the obvious counter-example for not supported encodings)
then I think we have to stick to enumerating them.

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog(at)svana(dot)org>   http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.

In response to

Responses

pgsql-patches by date

Next:From: Peter EisentrautDate: 2005-11-24 22:35:11
Subject: Re: [PATCH] Formatting patch for psql
Previous:From: Simon RiggsDate: 2005-11-24 18:03:50
Subject: Re: Space management for PGresult

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group