On Thu, Nov 24, 2005 at 03:45:12PM +0100, Peter Eisentraut wrote:
> Shouldn't you use PQmblen() to determine whether an encoding is
> single-byte, rather than having an enumerated list?
Actually, thinking about it the answer is no. The code is relying on
the fact that it's a charset that has ASCII as a subset. Unless someone
can say that every single-byte encoding we support has an ASCII subset
(EBCDIC being the obvious counter-example for not supported encodings)
then I think we have to stick to enumerating them.
Have a nice day,
Martijn van Oosterhout <kleptog(at)svana(dot)org> http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.
In response to
pgsql-patches by date
|Next:||From: Peter Eisentraut||Date: 2005-11-24 22:35:11|
|Subject: Re: [PATCH] Formatting patch for psql|
|Previous:||From: Simon Riggs||Date: 2005-11-24 18:03:50|
|Subject: Re: Space management for PGresult|