Skip site navigation (1) Skip section navigation (2)

Re: [PATCH] Formatting patch for psql

From: Martijn van Oosterhout <kleptog(at)svana(dot)org>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCH] Formatting patch for psql
Date: 2005-11-24 17:33:20
Message-ID: 20051124173307.GA29774@svana.org (view raw or flat)
Thread:
Lists: pgsql-patches
On Thu, Nov 24, 2005 at 03:45:12PM +0100, Peter Eisentraut wrote:
> Martijn van Oosterhout wrote:
> > Here is my patch to make psql handle multi-line output sanely.
> > Instead of embedded newlines splattering your output across the
> > screen, everything gets indented to the right column.
> 
> Shouldn't you use PQmblen() to determine whether an encoding is 
> single-byte, rather than having an enumerated list?

Probably. I went through psql to make sure there wasn't a function that
did it, I didn't think of checking for undocumented libpq functions.
Actually, I see there may be another there that would be nice:
PQdsplen.

Will look into it, thanks.

Have a nice day,
-- 
Martijn van Oosterhout   <kleptog(at)svana(dot)org>   http://svana.org/kleptog/
> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.

In response to

pgsql-patches by date

Next:From: Simon RiggsDate: 2005-11-24 18:03:50
Subject: Re: Space management for PGresult
Previous:From: Tom LaneDate: 2005-11-24 17:32:01
Subject: Re: Space management for PGresult

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group