Skip site navigation (1) Skip section navigation (2)

pgsql: Get rid of ExecAssignResultTypeFromOuterPlan() and make all plan

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Get rid of ExecAssignResultTypeFromOuterPlan() and make all plan
Date: 2005-11-23 20:27:59
Message-ID: 20051123202759.3232ADBA7B@svr1.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Get rid of ExecAssignResultTypeFromOuterPlan() and make all plan node types
generate their output tuple descriptors from their target lists (ie, using
ExecAssignResultTypeFromTL()).  We long ago fixed things so that all node
types have minimally valid tlists, so there's no longer any good reason to
have two different ways of doing it.  This change is needed to fix bug
reported by Hayden James: the fix of 2005-11-03 to emit the correct column
names after optimizing away a SubqueryScan node didn't work if the new
top-level plan node used ExecAssignResultTypeFromOuterPlan to generate its
tupdesc, since the next plan node down won't have the correct column labels.

Modified Files:
--------------
    pgsql/src/backend/executor:
        execUtils.c (r1.128 -> r1.129)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/execUtils.c.diff?r1=1.128&r2=1.129)
        nodeHash.c (r1.98 -> r1.99)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeHash.c.diff?r1=1.98&r2=1.99)
        nodeLimit.c (r1.22 -> r1.23)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeLimit.c.diff?r1=1.22&r2=1.23)
        nodeMaterial.c (r1.50 -> r1.51)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeMaterial.c.diff?r1=1.50&r2=1.51)
        nodeSetOp.c (r1.18 -> r1.19)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeSetOp.c.diff?r1=1.18&r2=1.19)
        nodeSort.c (r1.51 -> r1.52)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeSort.c.diff?r1=1.51&r2=1.52)
        nodeUnique.c (r1.49 -> r1.50)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/nodeUnique.c.diff?r1=1.49&r2=1.50)
    pgsql/src/include/executor:
        executor.h (r1.120 -> r1.121)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/executor/executor.h.diff?r1=1.120&r2=1.121)

pgsql-committers by date

Next:From: Tom LaneDate: 2005-11-23 20:28:05
Subject: pgsql: Get rid of ExecAssignResultTypeFromOuterPlan() and make all plan
Previous:From: Tom LaneDate: 2005-11-23 17:21:23
Subject: pgsql: Fix problems with rewriter failing to set Query.hasSubLinks when

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group