Re: Interval aggregate regression failure (expected seems

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Paesold <mpaesold(at)gmx(dot)at>, Michael Glaesemann <grzm(at)myrealbox(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Interval aggregate regression failure (expected seems
Date: 2005-11-15 03:07:49
Message-ID: 200511150307.jAF37nN25508@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Michael Paesold <mpaesold(at)gmx(dot)at> writes:
> > Would you mind reporting this to RedHat Bugzilla? I believe a bug report
> > from you would have more weight then mine, because you actually
> > understand what's going on here. :-)
>
> Actually, given the thought that this may be an artifact of keeping an
> intermediate value in a wider-than-normal register rather than genuinely
> rearranging the computation, I'm not certain it is a compiler bug.
> We'd have to study it a lot more closely before filing it as one, anyway.
>
> If you accept the idea that the pentium4 answer is the right one,
> then what we really need to do is focus on a better rounding rule than
> "strict truncation". I was toying with the notion of adding the
> equivalent of half a microsecond to the fractional-day value before
> truncating it to integer. But I'm not certain that that wouldn't have
> some bad effects in other cases.

Looking at the code, do we need additional rint() calls in there, or
rint(x + 0.5)? Frankly, I am confused why interval_div() has caused
such problems for us? Are we going at this the right way?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message ITS ONT Alcazar, Jose Aguedo C 2005-11-15 03:19:27 Major Problem, need help! Can't run our website!
Previous Message Robert Treat 2005-11-15 03:02:32 Re: functions marked STABLE not allowed to do INSERT

Browse pgsql-patches by date

  From Date Subject
Next Message Andreas Seltenreich 2005-11-15 16:33:06 Re: TODO item -- Improve psql's handling of multi-line queries
Previous Message Alvaro Herrera 2005-11-15 02:40:52 Re: [HACKERS] Per-table freeze limit proposal