Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Rename the members of CommandDest enum so

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: "Marc G(dot) Fournier" <scrappy(at)postgresql(dot)org>
Cc: Alvaro Herrera <alvherre(at)svr1(dot)postgresql(dot)org>,pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Rename the members of CommandDest enum so
Date: 2005-11-03 20:19:41
Message-ID: 200511032019.jA3KJfx21543@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committerspgsql-hackers
Marc G. Fournier wrote:
> 
> Is this an appropriate commit for post-Beta?  Does it fix a critical bug 
> that will prevent a release from happening? :(
> 

Seems it was needed to get PL/PHP to compile cleanly, and we all know
that was a pain the past.  I think it is OK as long as it it was just
renaming, and I think Tom eyeballed it.

---------------------------------------------------------------------------


> On Thu, 3 Nov 2005, Alvaro Herrera wrote:
> 
> > Log Message:
> > -----------
> > Rename the members of CommandDest enum so they don't collide with other uses of
> > those names.  (Debug and None were pretty bad names anyway.)  I hope I catched
> > all uses of the names in comments too.
> >
> > Modified Files:
> > --------------
> >    pgsql/src/backend/access/common:
> >        printtup.c (r1.92 -> r1.93)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/access/common/printtup.c.diff?r1=1.92&r2=1.93)
> >    pgsql/src/backend/commands:
> >        async.c (r1.126 -> r1.127)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/async.c.diff?r1=1.126&r2=1.127)
> >        copy.c (r1.253 -> r1.254)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/copy.c.diff?r1=1.253&r2=1.254)
> >        portalcmds.c (r1.43 -> r1.44)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/commands/portalcmds.c.diff?r1=1.43&r2=1.44)
> >    pgsql/src/backend/executor:
> >        spi.c (r1.143 -> r1.144)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/spi.c.diff?r1=1.143&r2=1.144)
> >        tstoreReceiver.c (r1.14 -> r1.15)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/executor/tstoreReceiver.c.diff?r1=1.14&r2=1.15)
> >    pgsql/src/backend/postmaster:
> >        postmaster.c (r1.472 -> r1.473)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/postmaster/postmaster.c.diff?r1=1.472&r2=1.473)
> >    pgsql/src/backend/tcop:
> >        dest.c (r1.66 -> r1.67)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/dest.c.diff?r1=1.66&r2=1.67)
> >        postgres.c (r1.467 -> r1.468)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/postgres.c.diff?r1=1.467&r2=1.468)
> >        pquery.c (r1.95 -> r1.96)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/tcop/pquery.c.diff?r1=1.95&r2=1.96)
> >    pgsql/src/backend/utils/error:
> >        elog.c (r1.165 -> r1.166)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/error/elog.c.diff?r1=1.165&r2=1.166)
> >    pgsql/src/backend/utils/misc:
> >        guc.c (r1.296 -> r1.297)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/misc/guc.c.diff?r1=1.296&r2=1.297)
> >    pgsql/src/include/tcop:
> >        dest.h (r1.47 -> r1.48)
> >        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/include/tcop/dest.h.diff?r1=1.47&r2=1.48)
> >
> > ---------------------------(end of broadcast)---------------------------
> > TIP 1: if posting/reading through Usenet, please send an appropriate
> >       subscribe-nomail command to majordomo(at)postgresql(dot)org so that your
> >       message can get through to the mailing list cleanly
> >
> 
> ----
> Marc G. Fournier           Hub.Org Networking Services (http://www.hub.org)
> Email: scrappy(at)hub(dot)org           Yahoo!: yscrappy              ICQ: 7615664
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Jim C. NasbyDate: 2005-11-03 21:34:24
Subject: Re: slru.c race condition (was Re: TRAP: FailedAssertion("!((itemid)->lp_flags
Previous:From: Simon RiggsDate: 2005-11-03 20:12:46
Subject: Re: Reducing the overhead of NUMERIC data

pgsql-committers by date

Next:From: User AmDate: 2005-11-03 20:30:59
Subject: press - pr: Set the release date to 9 nov.
Previous:From: Bruce MomjianDate: 2005-11-03 20:11:34
Subject: Re: TO_CHAR and Separate thousand

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group