Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] expanded \df+ display broken in beta4

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Cc: Michael Paesold <mpaesold(at)gmx(dot)at>,Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>
Subject: Re: [HACKERS] expanded \df+ display broken in beta4
Date: 2005-10-27 13:06:34
Message-ID: 200510271306.j9RD6Yu13281@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Bruce Momjian wrote:
> Michael Paesold wrote:
> > Bruce Momjian wrote:
> > > Michael Paesold wrote:
> > > 
> > >>Tom Lane wrote:
> > >>
> > >>>"Michael Paesold" <mpaesold(at)gmx(dot)at> writes:
> > >>>
> > >>>>Robert Treat wrote:
> > >>>>
> > >>>>>ISTM even a GUC to enable/disable would have been better scheme than
> > >>>>>what we have now; we are basically leaving no options for those who
> > >>>>>found the old behavior useful, while what we had before would at least
> > >>>>>let people switch back and forth. 
> > >>>
> > >>>>I think Robert is right here and the new behaviour is a step backwards.
> > >>>
> > >>>Should we revert the patch for the time being, and take another go at it
> > >>>in 8.2?
> > 
> > > One idea is to hack \d not to honor \x, and let the others honor it.
> > > That would probably hit most of the cases people will use in 8.1.
> > > 
> > > In fact, \d is pretty special because it is more of a group of outputs,
> > > unlike \df, which is a single table output.
> > 
> > +1 from me. That seems like a workable compromise and should probably 
> > meet the needs of the author of the patch to change the \x behavior.
> 
> OK, here is a patch that disables expanded output only for \d tablename.

The patch is even easier than the original patch.  There was never any
need for "normal_query".  Because the structure is a copy of the
session-wide structure, we can just set expanded to true/false as
desired.

I have applied this updated patch which simply turns off expanded mode
for \d tablename.  That seemed like the only complex backslash output in
describe.c.  I have also updated the release notes.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Martijn van OosterhoutDate: 2005-10-27 13:18:41
Subject: Re: ERROR: invalid memory alloc request size <a_big_number_here>
Previous:From: Bruce MomjianDate: 2005-10-27 12:54:57
Subject: Re: ERROR: invalid memory alloc request size <a_big_number_here>

pgsql-patches by date

Next:From: Tom LaneDate: 2005-10-27 13:48:48
Subject: Re: A script to make some bug report easier
Previous:From: Qingqing ZhouDate: 2005-10-27 09:06:37
Subject: A script to make some bug report easier

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group