Skip site navigation (1) Skip section navigation (2)

Re: pidfile location missing after restarting crashed server in 8.1

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Robert Treat <xzilla(at)users(dot)sourceforge(dot)net>,pgsql-hackers(at)postgresql(dot)org
Subject: Re: pidfile location missing after restarting crashed server in 8.1
Date: 2005-10-26 19:51:18
Message-ID: 20051026195118.GE27006@surnet.cl (view raw or flat)
Thread:
Lists: pgsql-hackers
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> writes:
> > Tom Lane wrote:
> >> Yeah: it's now being accessed by a relative path (relative to $PGDATA,
> >> which we have already chdir'd into at this point).
> 
> > So we should include PGDATA in the error message (DataDir actually, I
> > guess).
> 
> I don't think that follows.  The code prints exactly the path name it's
> using to access the file, and I think that's exactly what it should
> print.

It's not useful for the user that way.  Besides, we know what we did
chdir() to, so we could present that information to the user.

-- 
Alvaro Herrera
"Amanece.                                               (Ignacio Reyes)
 El Cerro San Cristóbal me mira, cínicamente, con ojos de virgen"

In response to

pgsql-hackers by date

Next:From: Jim C. NasbyDate: 2005-10-26 20:24:57
Subject: TRAP: FailedAssertion("!((itemid)->lp_flags & 0x01)", File: "nbtsearch.c", Line: 89)
Previous:From: Andrew DunstanDate: 2005-10-26 19:44:45
Subject: localhost in pgpass file?

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group