Skip site navigation (1) Skip section navigation (2)

pgsql: Code review for spi_query/spi_fetchrow patch: handle errors

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors
Date: 2005-10-18 17:13:14
Message-ID: 20051018171314.60F25D94DD@svr1.postgresql.org (view raw or flat)
Thread:
Lists: pgsql-committers
Log Message:
-----------
Code review for spi_query/spi_fetchrow patch: handle errors sanely,
avoid leaking memory.  I would add a regression test for error handling
except it seems eval{} can't be used in unprivileged plperl :-(

Modified Files:
--------------
    pgsql/src/pl/plperl:
        SPI.xs (r1.16 -> r1.17)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/SPI.xs.diff?r1=1.16&r2=1.17)
        plperl.c (r1.93 -> r1.94)
        (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/pl/plperl/plperl.c.diff?r1=1.93&r2=1.94)

Responses

pgsql-committers by date

Next:From: David FetterDate: 2005-10-18 18:28:16
Subject: Re: pgsql: Code review for spi_query/spi_fetchrow patch: handle errors
Previous:From: User Doudou586Date: 2005-10-18 16:05:55
Subject: press - pr: version 1.0

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group