Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Patching dblink.c to avoid warning about

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Joe Conway <mail(at)joeconway(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>,David Fetter <david(at)fetter(dot)org>,Jonathan Beit-Aharon <jbeitaharon(at)intrusic(dot)com>
Subject: Re: [HACKERS] Patching dblink.c to avoid warning about
Date: 2005-10-17 12:36:00
Message-ID: 200510171236.j9HCa0L00844@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Joe Conway wrote:
> Tom Lane wrote:
> > I think it would be shorter and clearer to write
> > 
> > 	remoteConn  *remconn = NULL;
> > 	...
> > 	remconn = rconn;
> > 	...
> > 	remconn->newXactForCursor = TRUE;
> > 
> > Also, you might be able to combine this variable with the existing
> > rconn local variable and thus simplify the code even more.
> 
> Thanks for the review Tom -- as usual, great suggestions. The attached 
> (simpler) patch makes use of your advice. If there are no objections, 
> I'll apply this tomorrow evening.

Looks good.  Thanks.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Peter EisentrautDate: 2005-10-17 13:18:40
Subject: Re: Can I use variable to store sql data - II
Previous:From: NosyManDate: 2005-10-17 06:59:49
Subject: Can I use variable to store sql data - II

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group