Joe Conway wrote:
> Tom Lane wrote:
> > I think it would be shorter and clearer to write
> > remoteConn *remconn = NULL;
> > ...
> > remconn = rconn;
> > ...
> > remconn->newXactForCursor = TRUE;
> > Also, you might be able to combine this variable with the existing
> > rconn local variable and thus simplify the code even more.
> Thanks for the review Tom -- as usual, great suggestions. The attached
> (simpler) patch makes use of your advice. If there are no objections,
> I'll apply this tomorrow evening.
Looks good. Thanks.
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
In response to
pgsql-patches by date
|Next:||From: Peter Eisentraut||Date: 2005-10-17 13:18:40|
|Subject: Re: Can I use variable to store sql data - II|
|Previous:||From: NosyMan||Date: 2005-10-17 06:59:49|
|Subject: Can I use variable to store sql data - II|