Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Darwin compile fixes

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: "Brian A(dot) Seklecki" <lavalamp(at)spiritual-machines(dot)org>,FC <qqa-1a89(at)myamail(dot)com>, netbsd-help(at)netbsd(dot)org,pgsql-ports(at)postgresql(dot)org,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [HACKERS] Darwin compile fixes
Date: 2005-10-13 15:50:22
Message-ID: 200510131550.j9DFoMl02732@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-ports
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Attached is a cleaned up version of the patch (without wrapping).  The
> > change is to use "$(CXX) $(CFLAGS)" instead of $(COMPILER).  Does this
> > change break OS/X?
> 
> Since our configure doesn't define CXX, I'm having a hard time imagining
> how it could fail to break it.
> 
> If we *did* define CXX, it would presumably point to g++, which would
> also break things since our source code is not C++ clean.
> 
> Even more to the point, Darwin isn't broken now --- at least it works
> fine on the powerbook I'm typing this on, and on the several OSX
> machines in the buildfarm.
> 
> I would like to know what this patch is alleged to fix before even
> considering applying it.

Yea, I see in Makefile.shlib:

	COMPILER = $(CC) $(CFLAGS)

so the code is really changing $CC to $CXX.  The big question is why
that change is required.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-ports by date

Next:From: Tadimeti, KesavDate: 2005-10-18 18:32:17
Subject: postgresql8.0.3/FreeBSD5.4/MIT or HEIMDAL KRB5
Previous:From: Tom LaneDate: 2005-10-13 04:28:56
Subject: Re: [HACKERS] Darwin compile fixes

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2005-10-13 15:57:56
Subject: Re: Minor point about contrib/xml2 functions "IMMUTABLE" marking
Previous:From: Michael FuhrDate: 2005-10-13 15:49:20
Subject: Re: BUG #1962: ECPG and VARCHAR

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group