Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] ECPG ignores SAVEPOINT if first statement of a transaction

From: Michael Meskes <meskes(at)postgresql(dot)org>
To: Michael Fuhr <mike(at)fuhr(dot)org>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,PostgreSQL-interfaces <pgsql-interfaces(at)postgresql(dot)org>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] ECPG ignores SAVEPOINT if first statement of a transaction
Date: 2005-09-12 12:36:34
Message-ID: 20050912123634.GB21008@1 (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-interfacespgsql-patches
On Sat, Aug 13, 2005 at 09:01:45AM -0600, Michael Fuhr wrote:
> If no statements have been executed in this transaction then committed
> is true, so ECPGtrans() ignores the current statement.  It looks
> like the code should make an extra consideration for SAVEPOINT in
> case it's the first statement.

I rearranged the whole code as it seemed to have more holes. This code
really was old. :-)

So could you please check with the lates CVS, either HEAD or 8.0?

> I'm also wondering if the check for a NULL return value from PQexec()
> is sufficient.  Shouldn't it also check for a non-NULL result that's
> anything other than PGRES_COMMAND_OK?

Yes, it should. I changed this as well.

Michael
-- 
Michael Meskes
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!

In response to

pgsql-hackers by date

Next:From: Josh BerkusDate: 2005-09-12 16:13:02
Subject: Re: Spinlocks, yet again: a new test case
Previous:From: Tino WildenhainDate: 2005-09-12 10:03:33
Subject: Re: Materialized Views in PostgreSQL

pgsql-patches by date

Next:From: Tom LaneDate: 2005-09-12 14:05:22
Subject: Re: SQL/XML publishing function experimental patch
Previous:From: Pavel StehuleDate: 2005-09-12 07:03:38
Subject: SQL/XML publishing function experimental patch

pgsql-interfaces by date

Next:From: fabrizio piccaDate: 2005-09-12 14:17:33
Subject: help needed on SPI_modifytuple.
Previous:From: Tom LaneDate: 2005-09-11 00:09:46
Subject: Re: Change of default type in DBD::Pg 1.42

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group