On Sat, Aug 13, 2005 at 09:01:45AM -0600, Michael Fuhr wrote:
> If no statements have been executed in this transaction then committed
> is true, so ECPGtrans() ignores the current statement. It looks
> like the code should make an extra consideration for SAVEPOINT in
> case it's the first statement.
I rearranged the whole code as it seemed to have more holes. This code
really was old. :-)
So could you please check with the lates CVS, either HEAD or 8.0?
> I'm also wondering if the check for a NULL return value from PQexec()
> is sufficient. Shouldn't it also check for a non-NULL result that's
> anything other than PGRES_COMMAND_OK?
Yes, it should. I changed this as well.
Email: Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: meskes(at)jabber(dot)org
Go SF 49ers! Go Rhein Fire! Use Debian GNU/Linux! Use PostgreSQL!
In response to
pgsql-hackers by date
|Next:||From: Josh Berkus||Date: 2005-09-12 16:13:02|
|Subject: Re: Spinlocks, yet again: a new test case|
|Previous:||From: Tino Wildenhain||Date: 2005-09-12 10:03:33|
|Subject: Re: Materialized Views in PostgreSQL|
pgsql-patches by date
|Next:||From: Tom Lane||Date: 2005-09-12 14:05:22|
|Subject: Re: SQL/XML publishing function experimental patch |
|Previous:||From: Pavel Stehule||Date: 2005-09-12 07:03:38|
|Subject: SQL/XML publishing function experimental patch|
pgsql-interfaces by date
|Next:||From: fabrizio picca||Date: 2005-09-12 14:17:33|
|Subject: help needed on SPI_modifytuple.|
|Previous:||From: Tom Lane||Date: 2005-09-11 00:09:46|
|Subject: Re: Change of default type in DBD::Pg 1.42 |