Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Duplicate object names in GRANT

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Gavin Sherry <swm(at)linuxworld(dot)com(dot)au>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, pgsql-hackers(at)postgresql(dot)org,pgsql-patches(at)postgresql(dot)org
Subject: Re: [HACKERS] Duplicate object names in GRANT
Date: 2005-08-12 21:20:39
Message-ID: 200508122120.j7CLKdL15764@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Patch applied.  Thanks.

I also added a comment above each one to mention why it is needed.

---------------------------------------------------------------------------


Gavin Sherry wrote:
> On Wed, 27 Jul 2005, Tom Lane wrote:
> 
> > Gavin Sherry <swm(at)linuxworld(dot)com(dot)au> writes:
> > > I ran across this yesterday on HEAD:
> >
> > > template1=# grant select on foo, foo to swm;
> > > ERROR:  tuple already updated by self
> >
> > Seems to fail similarly in every version back to 7.2; probably further,
> > but that's all I have running at the moment.
> >
> > > We could do away with the error by producing a unique list of object names
> > > -- but that would impose an extra cost on the common case.
> >
> > CommandCounterIncrement in the GRANT loop would be easier, likely.
> > I'm having a hard time getting excited about it though...
> 
> Yeah, its not that exciting but that error message would throw your
> average user.
> 
> I've attached a patch which calls CommandCounterIncrement() in each of the
> grant loops.
> 
> Thanks,
> 
> Gavin

Content-Description: 

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: explain analyze is your friend

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Tom LaneDate: 2005-08-12 21:38:02
Subject: Re: pthread stack on FreeBSD WAS: HEAD doesn't cope with libraries
Previous:From: Bruce MomjianDate: 2005-08-12 20:57:58
Subject: Re: pthread stack on FreeBSD WAS: HEAD doesn't cope with libraries

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-08-12 21:23:24
Subject: Re: patch for win32 dynloader
Previous:From: Tom LaneDate: 2005-08-12 21:14:49
Subject: Re: Bug in canonicalize_path()

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group