Skip site navigation (1) Skip section navigation (2)

Re: Bug in canonicalize_path()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: William ZHANG <uniware(at)zedware(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Bug in canonicalize_path()
Date: 2005-08-12 20:04:56
Message-ID: 200508122004.j7CK4uX21011@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, here is a version that errors out that I just applied and reversed
> > out when I saw your email.  Feel free to use it or discard it.
> 
> Sorry about that --- should have tried to mail you a bit sooner.
> 
> BTW, what's with the postmaster.c change?  Seems mistaken.

Actually, it is a cleanup.  The original path.c::get_progname() used an
exit() call in WIN32 because it didn't have frontend/backend-specific
code.  With specific versions, I could return a NULL from get_progname
and print a relivant message in postmaster.c on failure.  I doubt it
would ever happen, but it was a cleanup.  It isn't significant enough to
justify making a server-specific version of path.c on its own, however.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-patches by date

Next:From: Mary Edie MeredithDate: 2005-08-12 20:22:08
Subject: Re: [HACKERS] data on devel code perf dip
Previous:From: Tom LaneDate: 2005-08-12 20:01:47
Subject: Re: Bug in canonicalize_path()

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group