Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] For review: Server instrumentation patch

From: Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
To: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>
Cc: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>,Dave Page <dpage(at)vale-housing(dot)co(dot)uk>
Subject: Re: [HACKERS] For review: Server instrumentation patch
Date: 2005-08-12 12:40:59
Message-ID: 20050812124059.GA12111@alvh.no-ip.org (view raw or flat)
Thread:
Lists: pgsql-patches
On Fri, Aug 12, 2005 at 11:28:22AM +0000, Andreas Pflug wrote:
> Bruce Momjian wrote:
> 
> >
> >I did not include pg_logdir_ls because that was basically pg_ls_dir with
> >logic to decode the log file name and convert it to a timestamp.  That
> >seemed best done in the client.
> 
> IMHO omitting pg_logdir_ls is a bad idea, because the function is 
> intended to hide server internal's naming scheme from the user. We want 
> as few server side implementation specific client side code as possible. 

BTW, it surprised me that one of the functions (don't remember which
one) expected the log files to be named in a very specific fashion.  So
there's no flexibility for changing the log_prefix.  Probably it's not
so bad, but strange anyway.  Is this for "security" reasons?

-- 
Alvaro Herrera (<alvherre[a]alvh.no-ip.org>)
Y dijo Dios: "Que sea Satanás, para que la gente no me culpe de todo a mí."
"Y que hayan abogados, para que la gente no culpe de todo a Satanás"

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-08-12 15:37:51
Subject: Re: Bug in canonicalize_path()
Previous:From: Andreas PflugDate: 2005-08-12 11:28:22
Subject: Re: [HACKERS] For review: Server instrumentation patch

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group