Skip site navigation (1) Skip section navigation (2)

Re: Interval->day docs and regression tests

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Glaesemann <grzm(at)myrealbox(dot)com>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Interval->day docs and regression tests
Date: 2005-07-30 18:21:07
Message-ID: 200507301821.j6UIL8a02113@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Michael Glaesemann <grzm(at)myrealbox(dot)com> writes:
> > Please find attached diffs for documentation and simple regression  
> > tests for the new interval->day changes.
> 
> The buildfarm results suggest that justify_days is broken in the
> integer-datetimes case, eg from panda:
> 
> *** ./expected/interval.out     Sat Jul 30 16:20:48 2005
> --- ./results/interval.out      Sat Jul 30 16:24:31 2005
> ***************
> *** 238,243 ****
>   SELECT justify_days(interval '6 months 36 days 5 hours 4 minutes 3 seconds') as "7 mons 6 days 5 hours 4 mins 3 seconds";
>    7 mons 6 days 5 hours 4 mins 3 seconds 
>   ----------------------------------------
> !  @ 7 mons 6 days 5 hours 4 mins 3 secs
>   (1 row)
>   
> --- 238,243 ----
>   SELECT justify_days(interval '6 months 36 days 5 hours 4 minutes 3 seconds') as "7 mons 6 days 5 hours 4 mins 3 seconds";
>    7 mons 6 days 5 hours 4 mins 3 seconds 
>   ----------------------------------------
> !  @ 1 mon 186 days 5 hours 4 mins 3 secs
>   (1 row)

Thanks, fixed and code cleaned up.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2005-07-30 18:29:55
Subject: Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive times
Previous:From: Rocco AltierDate: 2005-07-30 18:08:20
Subject: Re: [COMMITTERS] pgsql: Add GUC variables to control keep-alive times for idle, interval,

pgsql-patches by date

Next:From: Petr JelinekDate: 2005-07-30 18:53:14
Subject: Re: per user/database connections limit again
Previous:From: Bruce MomjianDate: 2005-07-30 17:15:45
Subject: Re: P.tch to mention cost-based delay in vacuum reference

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group