Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Kris Jurka <books(at)ejurka(dot)com>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval
Date: 2005-07-20 18:20:39
Message-ID: 200507201820.j6KIKdF25658@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers pgsql-patches

Kris Jurka wrote:
> Bruce Momjian wrote:
> > Log Message:
> > -----------
> > Add 'day' field to INTERVAL so 1 day interval can be distinguished from
> > 24 hours. This is very helpful for daylight savings time:
> >
>
> Seems to have broken the contrib/btree_gist interval regression tests
>
> http://pgbuildfarm.org/cgi-bin/show_log.pl?nm=dragonfly&dt=2005-07-20%2017:30:00

I have applied a patch which adds the 'date' value for interval to the
code. However, the regression still does not pass. Here is a query:

SELECT count(*) FROM intervaltmp WHERE a = '199 days 21:21:23'::interval;
count
-------
1
(1 row)

that should return 1, but returns 0 in the current code. Does anyone
have any ideas on a fix?

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message User Bklawans 2005-07-20 22:48:58 bizgres - bizgres: New Directory
Previous Message Bruce Momjian 2005-07-20 18:17:39 pgsql: /contrib/btree_gist adjustments for new 'day' interval value.

Browse pgsql-patches by date

  From Date Subject
Next Message Rocco Altier 2005-07-20 18:42:15 Re: [COMMITTERS] pgsql: Add 'day' field to INTERVAL so 1 day interval
Previous Message Peter Eisentraut 2005-07-20 18:12:01 Re: Changes for AIX buildfarm