pgsql: Don't try to constant-fold functions returning RECORD.

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Don't try to constant-fold functions returning RECORD.
Date: 2005-07-03 21:14:19
Message-ID: 20050703211419.8D5085285B@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Don't try to constant-fold functions returning RECORD. We were never
able to do this before, but I had tried to make an exception for functions
with OUT parameters. Michael Fuhr found one problem with it already, and
I found another, which was it didn't work for strict functions with a
NULL input. While both of these could be worked around, the probability
that there are more gotchas seems high; I think prudence dictates just
reverting to the former behavior for now. Accordingly, remove the kluge
added to get_expr_result_type() for Michael's case.

Modified Files:
--------------
pgsql/src/backend/optimizer/util:
clauses.c (r1.199 -> r1.200)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/optimizer/util/clauses.c.diff?r1=1.199&r2=1.200)
pgsql/src/backend/utils/fmgr:
funcapi.c (r1.23 -> r1.24)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/fmgr/funcapi.c.diff?r1=1.23&r2=1.24)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2005-07-03 21:56:19 pgsql: Fix memory leak in plperl_hash_from_tuple(), per report from
Previous Message Peter Eisentraut 2005-07-03 18:54:29 pgsql: Support cross compilation by compiling "zic" with a native