Skip site navigation (1) Skip section navigation (2)

Re: [HACKERS] Problem with dblink regression test - FIXED

From: "Jim C(dot) Nasby" <decibel(at)decibel(dot)org>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>,pgsql-patches(at)postgresql(dot)org
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: [HACKERS] Problem with dblink regression test - FIXED
Date: 2005-06-29 00:23:49
Message-ID: 20050629002349.GG50976@decibel.org (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
On Tue, Jun 28, 2005 at 02:28:11PM -0400, Andrew Dunstan wrote:
> 
> 
> Jim C. Nasby wrote:
> 
> >All the logs for the most recent run against HEAD are now at
> >http://stats.distributed.net/~buildfarm/
> >
> > 
> >
> >
> 
> A quick look shows that when you use --with-libraries=/foo/bar the 
> generated link line for libraries says
> 
>  -L/foo/bar -lpq
> 
> and it should probably be the other way around (as it is for the 
> executables).
> 
> So I suspect we need some makefile tuning.

You were correct. This patch fixes it:
Index: Makefile.shlib
===================================================================
RCS file: /projects/cvsroot/pgsql/src/Makefile.shlib,v
retrieving revision 1.90
diff -c -r1.90 Makefile.shlib
*** Makefile.shlib      20 Nov 2004 21:13:04 -0000      1.90
--- Makefile.shlib      29 Jun 2005 00:21:10 -0000
***************
*** 240,246 ****
    SHLIB_LINK          += -ltermcap -lstdc++.r4 -lbind -lsocket -L/boot/develop/lib/x86
  endif
  
! SHLIB_LINK := $(filter -L%, $(LDFLAGS)) $(SHLIB_LINK)
  ifeq ($(enable_rpath), yes)
  SHLIB_LINK += $(rpath)
  endif
--- 240,246 ----
    SHLIB_LINK          += -ltermcap -lstdc++.r4 -lbind -lsocket -L/boot/develop/lib/x86
  endif
  
! SHLIB_LINK := $(SHLIB_LINK) $(filter -L%, $(LDFLAGS))
  ifeq ($(enable_rpath), yes)
  SHLIB_LINK += $(rpath)
  endif

-- 
Jim C. Nasby, Database Consultant               decibel(at)decibel(dot)org 
Give your computer some brain candy! www.distributed.net Team #1828

Windows: "Where do you want to go today?"
Linux: "Where do you want to go tomorrow?"
FreeBSD: "Are you guys coming, or what?"

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2005-06-29 01:16:20
Subject: Re: Dbsize backend integration
Previous:From: Stephen FrostDate: 2005-06-29 00:23:04
Subject: Re: [PATCHES] Users/Groups -> Roles

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-06-29 01:16:20
Subject: Re: Dbsize backend integration
Previous:From: Stephen FrostDate: 2005-06-29 00:23:04
Subject: Re: [PATCHES] Users/Groups -> Roles

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group