Re: [BUGS] BUG #1707: statistics collector starts with stats_start_collector

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)surnet(dot)cl>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Federico Di Gregorio <fog(at)initd(dot)org>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [BUGS] BUG #1707: statistics collector starts with stats_start_collector
Date: 2005-06-28 01:13:20
Message-ID: 200506280113.j5S1DKF12840@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-patches

Alvaro Herrera wrote:
> On Mon, Jun 27, 2005 at 08:51:46PM -0400, Bruce Momjian wrote:
> > Tom Lane wrote:
> > > Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > > > The following patch removes the GUC stats_start_collector. The stats
> > > > process is now always started.
> > >
> > > WAIT a second!!!
> > >
> > > That was *not* the agenda; the collector is only supposed to start if
> > > you turn on at least one of the collection options.
> >
> > Really? I thought the process always started and it just sits there if
> > nothing is fed to it, no?
>
> No, the process is only started if you ask for it (which is true by
> default).
>
> > In fact, if it wasn't started from the beginning, we couldn't enable
> > query strings without restarting the server.
>
> That's true -- if you start with the collector disabled, you can't
> enable query strings.
>
> > The current default is true, meaning it always started.
>
> Yes, but you can turn it off.

OK, but if all the stats* variables are off, what overhead is there in
having the stats process run? I would think very little, and if we turn
it always on, we make configuration easier and remove a GUC variable.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message Alvaro Herrera 2005-06-28 01:29:40 Re: [BUGS] BUG #1707: statistics collector starts with stats_start_collector
Previous Message Alvaro Herrera 2005-06-28 01:09:59 Re: [BUGS] BUG #1707: statistics collector starts with stats_start_collector

Browse pgsql-patches by date

  From Date Subject
Next Message Michael Glaesemann 2005-06-28 01:15:50 Re: Performance analysis of plpgsql code
Previous Message Alvaro Herrera 2005-06-28 01:09:59 Re: [BUGS] BUG #1707: statistics collector starts with stats_start_collector