Skip site navigation (1) Skip section navigation (2)

PL/Python error checking

From: Michael Fuhr <mike(at)fuhr(dot)org>
To: pgsql-patches(at)postgresql(dot)org
Subject: PL/Python error checking
Date: 2005-06-27 13:53:23
Message-ID: 20050627135323.GA94604@winnie.fuhr.org (view raw or flat)
Thread:
Lists: pgsql-patches
This patch addresses the problem mentioned in the "process crash
when a plpython function returns unicode" thread:

http://archives.postgresql.org/pgsql-bugs/2005-06/msg00105.php

In several places PL/Python was calling PyObject_Str() and then
PyString_AsString() without checking if the former had returned
NULL to indicate an error.  PyString_AsString() doesn't expect a
NULL argument, so passing one causes a segmentation fault.  This
patch adds checks for NULL and raises errors via PLy_elog(), which
prints details of the underlying Python exception.  The patch also
adds regression tests for these checks.  All tests pass on my
Solaris 9 box running HEAD and Python 2.4.1.

In one place the patch doesn't call PLy_elog() because that could
cause infinite recursion; see the comment I added.  I'm not sure
how to test that particular case or whether it's even possible to
get an error there: the value that the code should check is the
Python exception type, so I wonder if a NULL value "shouldn't
happen."  This patch converts NULL to "Unknown Exception" but I
wonder if an Assert() would be appropriate.

The patch is against HEAD but the same changes should be applied
to earlier versions because they have the same problem.  The patch
might not apply cleanly against earlier versions -- will the committer
take care of little differences or should I submit different versions
of the patch?

-- 
Michael Fuhr
http://www.fuhr.org/~mfuhr/

Responses

pgsql-patches by date

Next:From: Karel ZakDate: 2005-06-27 14:21:23
Subject: Re: limiting connections per user/database
Previous:From: Tom LaneDate: 2005-06-27 13:51:02
Subject: Re: limiting connections per user/database

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group