Skip site navigation (1) Skip section navigation (2)

Re: COPY FROM performance improvements

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Luke Lonergan <llonergan(at)greenplum(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,Alon Goldshuv <agoldshuv(at)greenplum(dot)com>,Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-patches(at)postgresql(dot)org
Subject: Re: COPY FROM performance improvements
Date: 2005-06-27 01:51:04
Message-ID: 200506270151.j5R1p4H15631@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Please change 'if(' to 'if (', and remove parenthese like this:

       for(start = s; (*s != c) && (s < (start + len)) ; s++)

My only other comment is, "Yow, that is a massive patch".

---------------------------------------------------------------------------

Luke Lonergan wrote:
> Tom,
> 
> > Is it really faster than appendStringInfoString or
> > appendBinaryStringInfo?
> 
> Apparently not, attached patch strips out the other bytebuffer and replaces
> it with appendBinaryStringInfo.
> 
> - Luke
> 

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
>     (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-06-27 01:54:04
Subject: Re: ToDo: Allow PL/pgSQL EXECUTE query_var INTO record_var;
Previous:From: Bruce MomjianDate: 2005-06-27 01:40:07
Subject: Re: Escape patch applied

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group