Tom Lane wrote:
> Neil Conway <neilc(at)samurai(dot)com> writes:
> > Tom Lane wrote:
> >> I think mostly what you are doing here is causing code drift from the
> >> upstream "zic" code. I don't think that's a very good idea, since we
> >> do need to be able to track and apply bug fixes from them from time
> >> to time ...
> > Why run pgindent on the timezone code, then? That seems guaranteed to
> > cause a lot more merge headaches...
> Well, it's certainly hopeless to expect "patch" to fix it :-(. But the
> further the code drifts the harder it gets to compare manually.
> This isn't an academic concern; I went through it once already, and I
> expect we'll want to do it again every release cycle when we sync the
> zic database with upstream.
I think the idea is that we will pgindent the new release of the
timezone code and then diff that against our current CVS.
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
In response to
pgsql-patches by date
|Next:||From: Mark Kirkwood||Date: 2005-06-21 04:44:36|
|Subject: Re: TODO Item - Return compressed length of TOAST datatypes|
|Previous:||From: Neil Conway||Date: 2005-06-21 02:09:42|
|Subject: pg_restore: fix bogosity|