pgsql: >> Do you agree that using a hashtable for it in general is a

From: momjian(at)svr1(dot)postgresql(dot)org (Bruce Momjian)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: >> Do you agree that using a hashtable for it in general is a
Date: 2005-06-15 00:09:27
Message-ID: 20050615000927.30FFD528CE@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
>> Do you agree that using a hashtable for it in general is a good idea
>> assuming this sideeffect is removed, though?
>
>I have no problem with the hashtable, only with preloading it with
>everything. What I'd like to see is that the table inherited at fork()
>contains just the data for the default timezone. (At least in the
>normal case where that setting hasn't been changed since postmaster
>start.)

Here's a patch doing this. Changes score_timezone not to use pg_tzset(),
and thus not loading all the zones in the cache. The actual timezone
being picked will be set using set_global_timezone() which in turn calls
pg_tzset() and loads it in the cache.

Magnus Hagander

Modified Files:
--------------
pgsql/src/timezone:
pgtz.c (r1.32 -> r1.33)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/timezone/pgtz.c.diff?r1=1.32&r2=1.33)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2005-06-15 00:15:08 pgsql: Support 3 and 4-byte unicode characters.
Previous Message Bruce Momjian 2005-06-14 23:59:32 pgsql: Now \d show tablespace of indices per discussion.