Re: log_line_prefix additions

Patch additions added to the patch queue.

---------------------------------------------------------------------------

Andrew Dunstan wrote:
>
>
> Ed L. wrote:
>
> >Attached also is a patch to comments in sample postgresql.conf file.
> >
> >Subject: [PATCHES] log_line_prefix additions
> >Date: Wednesday August 25 2004 3:26
> >From: "Ed L." <pgsql(at)bluepolka(dot)net>
> >To: pgsql-patches(at)postgresql(dot)org
> >
> >This patch against 8.0.0beta1 source adds log_line_prefix options for
> >millisecond timestamps (%m), remote host (%h), and remote port (%P). The
> >milliseconds are useful for QPS measurements, and the remote port is
> >worthless to us as part of %r.
> >
> >
> >
> [snip]
>
> >+ struct timezone tz = {0, 0};
> >+
> >+ gettimeofday(&tv, &tz);
> >
> >
> >
>
>
>
> The timezone is pointless. Just pass NULL as the second argument to
> gettimeofday().
>
> Also, I don't understand what you mean by the remote port being
> "worthless to us as part of %r." Please explain.
>
> cheers
>
> andrew
>
>
>
> ---------------------------(end of broadcast)---------------------------
> TIP 8: explain analyze is your friend
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073