Re: lastval()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: John Hansen <john(at)geeknet(dot)com(dot)au>
Cc: Neil Conway <neilc(at)samurai(dot)com>, Dennis Bjorklund <db(at)zigo(dot)dhs(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: lastval()
Date: 2005-05-11 03:45:23
Message-ID: 200505110345.j4B3jNY03213@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

John Hansen wrote:
> > > > What do people think of this idea? (Tom seems opposed, I'm just
> > > > wondering if there are other opinions out there.)
> > >
> > > I'm all for it. Even more so if the 'currval(void) called before
> > > nextval(seq_name)' error message could be supressed by a
> > GUC variable
> > > and return 0 instead.
> >
> > Why zero and no error?
>
> That's the exact behaviour of the "other database's" equivalent.
> Makes porting easier, and avoids hugely annoying error messages in the
> logfiles.

I think we would have to throw an error. It is hard to see how zero is
a valid return value. If you are getting too many errors in your logs,
fix the code.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-05-11 04:02:34 Re: [PATCHES] Cleaning up unreferenced table files
Previous Message Bruce Momjian 2005-05-11 03:44:38 Re: lastval()