python - be: Move fnExtraCalls list to pl.c.

From: jwp(at)pgfoundry(dot)org (James William Pye)
To: pgsql-committers(at)postgresql(dot)org
Subject: python - be: Move fnExtraCalls list to pl.c.
Date: 2005-04-23 22:57:31
Message-ID: 20050423225731.451711FB77C0@pgfoundry.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Move fnExtraCalls list to pl.c.

All insertions to the list occur after the call is made, thus allowing the
decision to be based on the success of the call(if it errored or if it's the end
of the VPC-SRF, there's no need to keep state).

Also select out fn_extra before hitting the plcall_new, and give fcinfo to
plcall_call instead(as pl is handling fnExtra now).

Be sure to set old and new's tableoid on creation for trigger pulls.
Remember to initialize the language if PythonLanguageOid is zero, otherwise the
function lookup code won't know to fetch the code out of probin; triggering an
assert in eval.(If a trigger was pulled before any Python function was called)

Modified Files:
--------------
be/include/pypg:
externs.h (r1.4 -> r1.5)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/python/be/include/pypg/externs.h.diff?r1=1.4&r2=1.5)
be/src:
globals.c (r1.4 -> r1.5)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/python/be/src/globals.c.diff?r1=1.4&r2=1.5)
pl.c (r1.7 -> r1.8)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/python/be/src/pl.c.diff?r1=1.7&r2=1.8)
be/src/call:
pl.c (r1.3 -> r1.4)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/python/be/src/call/pl.c.diff?r1=1.3&r2=1.4)
trigger.c (r1.3 -> r1.4)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/python/be/src/call/trigger.c.diff?r1=1.3&r2=1.4)
be/include/pypg/call:
pl.h (r1.2 -> r1.3)
(http://cvs.pgfoundry.org/cgi-bin/cvsweb.cgi/python/be/include/pypg/call/pl.h.diff?r1=1.2&r2=1.3)

Browse pgsql-committers by date

  From Date Subject
Next Message User Kimhanse 2005-04-24 00:02:47 tablelog - tablelog: New Directory
Previous Message Tom Lane 2005-04-23 22:54:23 pgsql: Repair two TIME WITH TIME ZONE bugs found by Dennis Vshivkov.