Re: HEAD \df doesn't show functions with no arguments

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Michael Fuhr <mike(at)fuhr(dot)org>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: HEAD \df doesn't show functions with no arguments
Date: 2005-04-01 04:53:18
Message-ID: 200504010453.j314rIl04288@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Tom Lane wrote:
> Michael Fuhr <mike(at)fuhr(dot)org> writes:
> > The problem appears to be that proargtypes[0] is now NULL instead
> > of 0. Here's a simplified version of the \df query:
>
> > SELECT proname
> > FROM pg_catalog.pg_proc p
> > WHERE p.proargtypes[0] <> 'pg_catalog.cstring'::pg_catalog.regtype
> > AND p.proname ~ '^foo$';
>
> We could fix it by changing <> to IS DISTINCT FROM ... but I've never
> been very happy with the idea that \df tries to suppress I/O functions
> anyway. How do you feel about removing the cstring test altogether?

I like the cstring test. I don't think users want to see functions they
can't call from SQL, and they will ask about them if we show them. Now,
if you want \dfS to show them and \df to not show them, that is OK with
me.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-04-01 04:57:47 Re: HEAD \df doesn't show functions with no arguments
Previous Message Tom Lane 2005-04-01 04:34:02 Re: HEAD \df doesn't show functions with no arguments

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-04-01 04:57:47 Re: HEAD \df doesn't show functions with no arguments
Previous Message Tom Lane 2005-04-01 04:34:02 Re: HEAD \df doesn't show functions with no arguments