Skip site navigation (1) Skip section navigation (2)

Re: Faster install-sh in C

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>,Peter Eisentraut <peter_e(at)gmx(dot)net>, Neil Conway <neilc(at)samurai(dot)com>,Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Faster install-sh in C
Date: 2005-03-25 23:05:02
Message-ID: 200503252305.j2PN52m23610@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > OK, what is 'install' doing for us that 'cp' and 'chmod' would not
> > already do?
> 
> Quite a lot of things, such as coping with busy target files --- not too
> important for headers, but very important for executables and shlibs.
> 
> We might be able to get away with this for just the headers, though,
> and that's certainly the bulk of the install work now.

Here is my next version of the patch that uses 'cp' and 'chmod' to
install multiple header files rather than 'install'.

I moved the file modes into variables so any changes are propogated to
src/include/Makefile.

This is 20 times faster than what we have now, 8 seconds vs 0.40 seconds.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2005-03-25 23:12:16
Subject: Re: Faster install-sh in C
Previous:From: Bruce MomjianDate: 2005-03-25 18:17:37
Subject: Re: Makefile breakage

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group