From:
Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To:
Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc:
Nicolai Tufar <ntufar(at)gmail(dot)com>,Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org,pgsql-hackers-win32(at)postgresql(dot)org
Subject:
Re: snprintf causes regression tests to fail
Date:
2005-03-02 04:23:08
Message-ID:
200503020423.j224N8m15255@candle.pha.pa.us (view raw or flat )
Thread:
2005-03-02 01:55:11 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 02:32:39 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 02:38:55 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 03:23:18 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 04:21:24 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 04:23:08 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 04:31:19 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 05:22:14 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 05:38:59 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 06:06:35 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-02 06:33:05 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 15:41:00 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 16:00:53 from pgsql(at)mohawksoft(dot)com
2005-03-02 18:21:47 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-02 21:38:28 from pgsql(at)mohawksoft(dot)com
2005-03-03 00:03:02 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-09 12:40:24 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-09 15:38:27 from pgsql(at)mohawksoft(dot)com
2005-03-10 03:51:27 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-10 19:22:13 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-10 21:26:47 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-10 22:43:48 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-11 16:21:23 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-10 23:55:06 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-11 00:21:41 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 01:29:49 from pgsql(at)mohawksoft(dot)com
2005-03-11 03:58:27 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-11 16:18:07 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 17:02:29 from pgsql(at)mohawksoft(dot)com
2005-03-11 17:14:26 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 17:23:36 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-11 17:37:24 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 17:44:19 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 04:10:12 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-11 05:58:11 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-11 06:14:31 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-11 06:41:39 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-11 23:58:15 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-12 15:00:14 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-16 06:00:21 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-16 11:36:50 from Nicolai Tufar <ntufar(at)gmail(dot)com>
2005-03-16 15:07:28 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-16 21:28:07 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-20 05:11:18 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-20 06:49:37 from Greg Stark <gsstark(at)mit(dot)edu>
2005-03-20 18:23:58 from Andrew Dunstan <andrew(at)dunslane(dot)net>
2005-05-05 21:03:11 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-14 18:55:16 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-14 19:19:14 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-14 19:39:19 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-14 19:41:01 from Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
2005-03-10 21:19:33 from Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
2005-03-02 12:09:37 from pgsql(at)mohawksoft(dot)com
Lists:
pgsql-hackers pgsql-hackers-win32 pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> Does it help if you flip the order of the snprintf and vsnprintf
> >> functions in snprintf.c?
>
> > Yes, it fixes the problem and I have applied the reordering with a
> > comment.
>
> Fascinating.
>
> > I will start working on fixing the large fmtpar allocations now.
>
> Quite honestly, this code is not worth micro-optimizing because it
> is fundamentally broken. See my other comments in this thread.
I am working on something that just counts the '%' characters in the
format string and allocates an array that size.
> Can we find a BSD-license implementation that follows the spec?
I would think NetBSD would be our best bet. I will download it and take
a look.
--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073
In response to
Responses
pgsql-hackers by date
Next :From: Bruce MomjianDate: 2005-03-02 04:31:19Subject : Re: snprintf causes regression tests to failPrevious :From : Tom LaneDate : 2005-03-02 04:21:24Subject : Re: snprintf causes regression tests to fail
pgsql-patches by date
Next :From: Bruce MomjianDate: 2005-03-02 04:31:19Subject : Re: snprintf causes regression tests to failPrevious :From : Tom LaneDate : 2005-03-02 04:21:24Subject : Re: snprintf causes regression tests to fail
pgsql-hackers-win32 by date
Next :From: Bruce MomjianDate: 2005-03-02 04:31:19Subject : Re: snprintf causes regression tests to failPrevious :From : Tom LaneDate : 2005-03-02 04:21:24Subject : Re: snprintf causes regression tests to fail
