Skip site navigation (1) Skip section navigation (2)

Re: snprintf causes regression tests to fail

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Nicolai Tufar <ntufar(at)gmail(dot)com>,Magnus Hagander <mha(at)sollentuna(dot)net>, pgsql-hackers(at)postgresql(dot)org,pgsql-hackers-win32(at)postgresql(dot)org
Subject: Re: snprintf causes regression tests to fail
Date: 2005-03-02 04:23:08
Message-ID: 200503020423.j224N8m15255@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-hackers-win32pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > Tom Lane wrote:
> >> Does it help if you flip the order of the snprintf and vsnprintf
> >> functions in snprintf.c?
> 
> > Yes, it fixes the problem and I have applied the reordering with a
> > comment.
> 
> Fascinating.
> 
> > I will start working on fixing the large fmtpar allocations now.
> 
> Quite honestly, this code is not worth micro-optimizing because it
> is fundamentally broken.  See my other comments in this thread.

I am working on something that just counts the '%' characters in the
format string and allocates an array that size.

> Can we find a BSD-license implementation that follows the spec?

I would think NetBSD would be our best bet.  I will download it and take
a look.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2005-03-02 04:31:19
Subject: Re: snprintf causes regression tests to fail
Previous:From: Tom LaneDate: 2005-03-02 04:21:24
Subject: Re: snprintf causes regression tests to fail

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-03-02 04:31:19
Subject: Re: snprintf causes regression tests to fail
Previous:From: Tom LaneDate: 2005-03-02 04:21:24
Subject: Re: snprintf causes regression tests to fail

pgsql-hackers-win32 by date

Next:From: Bruce MomjianDate: 2005-03-02 04:31:19
Subject: Re: snprintf causes regression tests to fail
Previous:From: Tom LaneDate: 2005-03-02 04:21:24
Subject: Re: snprintf causes regression tests to fail

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group