Re: [HACKERS] snprintf causes regression tests to fail

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql(at)mohawksoft(dot)com, Nicolai Tufar <ntufar(at)gmail(dot)com>, Magnus Hagander <mha(at)sollentuna(dot)net>, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] snprintf causes regression tests to fail
Date: 2005-02-28 20:35:18
Message-ID: 200502282035.j1SKZIn21122@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-hackers-win32 pgsql-patches

Tom Lane wrote:
> pgsql(at)mohawksoft(dot)com writes:
> > Do we have any idea about what format string causes the regression failure?
>
> I'll bet the problem is that configure.in is doing things in the wrong
> order: it computes INT64_FORMAT against the system printf before
> deciding we should use our own printf.

Ah, the problem was introduced here:

revision 1.401
date: 2005/02/24 02:12:15; author: tgl; state: Exp; lines: +13 -12
We aren't supposed to try to run test programs until after we've
verified that AC_TRY_RUN works.

The problem is that the PGAC_FUNC_PRINTF_ARG_CONTROL call was moved
below the printf 64-bit tests. This commited patch moves
PGAC_FUNC_PRINTF_ARG_CONTROL which is after we know AC_TRY_RUN works and
just before printf 64-bit args are tested.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 6.0 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2005-02-28 20:58:04 Re: [HACKERS] snprintf causes regression tests to fail
Previous Message Oleg Bartunov 2005-02-28 20:16:27 Re: serial as FK ?

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Tom Lane 2005-02-28 20:58:04 Re: [HACKERS] snprintf causes regression tests to fail
Previous Message Tom Lane 2005-02-28 19:51:46 Re: snprintf causes regression tests to fail

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2005-02-28 20:58:04 Re: [HACKERS] snprintf causes regression tests to fail
Previous Message Tom Lane 2005-02-28 19:51:46 Re: snprintf causes regression tests to fail