Re: [HACKERS] UTF8 or Unicode

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: lsunley(at)mb(dot)sympatico(dot)ca
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, tgl(at)sss(dot)pgh(dot)pa(dot)us, dpage(at)vale-housing(dot)co(dot)uk, oliver(at)opencloud(dot)com, zakkr(at)zf(dot)jcu(dot)cz, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] UTF8 or Unicode
Date: 2005-02-27 01:07:22
Message-ID: 200502270107.j1R17MU25285@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

lsunley(at)mb(dot)sympatico(dot)ca wrote:
> In <200502270055(dot)j1R0te122973(at)candle(dot)pha(dot)pa(dot)us>, on 02/26/05
> at 07:55 PM, Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> said:
>
> >lsunley(at)mb(dot)sympatico(dot)ca wrote:
> >> Further to my earlier e-mail, there would have to be two lines added to
> >> conversion_create.sql for each alternate function name
> >>
> >> Like:
> >>
> >> CREATE OR REPLACE FUNCTION ascii_to_whatever (INTEGER, INTEGER, CSTRING,
> >> CSTRING, INTEGER) RETURNS VOID AS '$libdir/ascmic', 'ascii_to_mic'
> >> LANGUAGE 'c' STRICT;
> >>
> >> CREATE CONVERSION pg_catalog.ascii_to_whatever FOR 'SQL_ASCII' TO
> >> 'MULE_INTERNAL' FROM ascii_to_whatever;
>
> >I would like to avoid bloating the system with aliases. I think it is OK
> >to have it happen with specific names but doing it for all the
> >combinations is too much, and these duplicates are in the system tables,
> >not in the C code. It just doesn't seem worth it to me.
>
> Good point, perhaps having a script generated that can be executed by the
> DBA to insert any deprecated conversion routine names would be the best
> route to take.

I am unsure why anyone would use the awkward names when you can more
easily supply the actual encoding names, and all the aliases work there.

Also, consider this is going to be a major release change so they are
going to dump/reload anyway. I see I need to update
conversion_create.sql too. I was previously only looking in C files.
Let me do a bigger search.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2005-02-27 04:09:43 Re: [HACKERS] UTF8 or Unicode
Previous Message Bruce Momjian 2005-02-27 00:55:40 Re: [HACKERS] UTF8 or Unicode

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-02-27 04:09:43 Re: [HACKERS] UTF8 or Unicode
Previous Message Bruce Momjian 2005-02-27 01:03:34 Re: [BUGS] BUG #1466: #maintenace_work_mem = 16384