Re: [HACKERS] UTF8 or Unicode

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Peter Eisentraut <peter_e(at)gmx(dot)net>
Cc: Tatsuo Ishii <t-ishii(at)sra(dot)co(dot)jp>, tgl(at)sss(dot)pgh(dot)pa(dot)us, dpage(at)vale-housing(dot)co(dot)uk, oliver(at)opencloud(dot)com, zakkr(at)zf(dot)jcu(dot)cz, PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] UTF8 or Unicode
Date: 2005-02-26 20:50:23
Message-ID: 200502262050.j1QKoNi10358@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Peter Eisentraut wrote:
> Am Freitag, 25. Februar 2005 05:51 schrieb Bruce Momjian:
> > so I see what he is saying. We are not consistent in favoring the
> > official names vs. the common names.
> >
> > I will work on a patch that people can review and test.
>
> I think this is what we should do:
>
> UNICODE => UTF8
> ALT => WIN866
> WIN => WIN1251
> TCVN => WIN1258
>
> That should clear it up.

OK, here is a patch that makes those changes.

The only uncertainty I have is with the the use of the TCVN conversion
routine names, e.g.:

SELECT CONVERT('foo' USING tcvn_to_utf_8);

I assume this is the same as:

SELECT CONVERT('foo', 'WIN1258', 'UTF8');
and
SELECT CONVERT('foo', 'TCVN', 'UTF8'); -- alias usage

So, why would people use the routine name? Both forms are documented.
The first one with USING does not accept aliases, while the others do.

I think this should be renamed to win1258_to_utf_8. However, this would
be an incompatibility. We should mention it in the release notes.

Other than that the other conversion files were already named fine, e.g.
ascii_to_utf_8 (no UNICODE), however it is utf_8 and not utf8. I am
unsure how to handle these.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 147.6 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message lsunley 2005-02-26 23:08:52 Re: [HACKERS] UTF8 or Unicode
Previous Message Jeff Davis 2005-02-26 19:05:57 Re: idea for concurrent seqscans

Browse pgsql-patches by date

  From Date Subject
Next Message lsunley 2005-02-26 23:08:52 Re: [HACKERS] UTF8 or Unicode
Previous Message Ron Mayer 2005-02-26 00:48:02 Re: [PATCHES] A way to let Vacuum warn if FSM settings are low.