Skip site navigation (1) Skip section navigation (2)

Re: BUG #1466: syslogger issues

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Magnus Hagander <mha(at)sollentuna(dot)net>
Cc: Andreas Pflug <pgadmin(at)pse-consulting(dot)de>,Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>,PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: BUG #1466: syslogger issues
Date: 2005-02-25 04:33:39
Message-ID: 200502250433.j1P4Xdf03667@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Previous version of patch removed from queue.

Your patch has been added to the PostgreSQL unapplied patches list at:

	http://momjian.postgresql.org/cgi-bin/pgpatches

It will be applied as soon as one of the PostgreSQL committers reviews
and approves it.

---------------------------------------------------------------------------


Magnus Hagander wrote:
> >>>>There is special code in the send_message_to_server_log 
> >>>
> >>>function to make
> >>>
> >>>>sure it's written directly to the file.
> >>>
> >>>If the logger is complaining, it's quite possibly because it's 
> >>>unable to
> >>>write to its file.  Now that you mention it, doesn't this 
> >code go into
> >>>infinite recursion if write_syslogger_file_binary() tries to ereport?
> >
> >Yes, apparently.
> >
> >Actually, elog.c code should look like this:
> >
> >if ((Log_destination & LOG_DESTINATION_STDERR) ...)
> >{
> >    if (am_syslogger)
> >       write_syslogger_file(buf.data, buf.len);
> >    else
> >       fwrite(buf.data, 1, buf.len, stderr);
> >}
> >
> >This avoids unnecessary pipe traffic (which might fail too) 
> >and gettext translation.
> 
> That's sort of what I thought, but without being certain at all.
> 
> 
> >Next, the elog call in write_syslogger_file_binary will almost 
> >certainly 
> >loop, so it should call write_stderr then (since eventlog is usually 
> >fixed-size with cyclic writing, even in out-of-disk-space conditions 
> >something might get logged).
> 
> Ok. I've included these changes in the attached patch. Haven't tested
> those specific codepaths, but the other changes still work...
> 
> >3rd, I've been proposing to have redirect_stderr=true on by default at 
> >least on win32 earlier, I still think this is reasonable.
> 
> It's already the default if you install from the MSI installer. 
> 
> //Magnus

Content-Description: stderr.patch

[ Attachment, skipping... ]

> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
> 
>                http://archives.postgresql.org

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-hackers by date

Next:From: Bruce MomjianDate: 2005-02-25 04:51:16
Subject: Re: UTF8 or Unicode
Previous:From: Bruce MomjianDate: 2005-02-25 04:00:48
Subject: Interesting NetBSD annual report

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-02-25 04:51:16
Subject: Re: UTF8 or Unicode
Previous:From: Bruce MomjianDate: 2005-02-25 04:01:32
Subject: Re: New FAQ questions. minor fixes

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group