Re: Shared dependency patch

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Shared dependency patch
Date: 2005-02-15 03:09:55
Message-ID: 200502150309.j1F39tc21216@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches


With us moving to a normal 8.1 release do you want to submit submit to
be applied to CVS?

---------------------------------------------------------------------------

Alvaro Herrera wrote:
> Hackers,
>
> Here is a newer version of the shared dependency patch. I keep the
> previous description below. Changes from the previous version are:
>
> - Removed several bogus elog(NOTICE)
> - Groups are checked at deletion for dependencies
> - I noticed a couple of tests (cluster and privileges) were leaving
> orphaned objects, so with this patch they would leave users behind.
> (consequently, future runs of the tests would fail).
> - Added simple regression testing.
>
> New files are
>
> src/backend/catalog/pg_shdepend.c
> src/include/catalog/pg_shdepend.h
> src/test/regress/sql/dependency.sql
> src/test/regress/expected/dependency.sql
>
> Comments are welcome.
>
>
> On Wed, Jan 26, 2005 at 09:04:53PM -0300, I wrote:
>
> > Patchers,
> >
> > Here is the latest installation of my shared dependency patch.
> > As some of you may remember, the purpose of this patch is to record
> > dependencies on shared objects, such as users, groups and tablespaces,
> > from regular database objects. This is done on a new shared system
> > catalog called pg_shdepend, so that when a backend wants to drop any
> > shared object, it can easily verify whether it is referenced in other
> > database.
> >
> > I have upgraded the patch to include references present in ACLs, and to
> > lock the objects appropiately before checking. To do this I had to
> > change the LOCKTAG struct somewhat, using a previous patch by Rod Taylor
> > (thanks Rod!); and add a LockSharedObject() function.
>
> --
> Alvaro Herrera (<alvherre[(at)]dcc(dot)uchile(dot)cl>)
> Major Fambrough: You wish to see the frontier?
> John Dunbar: Yes sir, before it's gone.

[ Attachment, skipping... ]

[ Attachment, skipping... ]

[ Attachment, skipping... ]

[ Attachment, skipping... ]

[ Attachment, skipping... ]

>
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
>
> http://archives.postgresql.org

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-02-15 04:08:18 Re: [PATCHES] WAL: O_DIRECT and multipage-writer (+ memory
Previous Message Bruce Momjian 2005-02-15 03:08:11 Re: Continue transactions after errors in psql