Errno checks for rmtree()

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Errno checks for rmtree()
Date: 2005-02-12 22:45:24
Message-ID: 200502122245.j1CMjOK21196@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

The following patch adds appropriate error messages based on the errno
returned from rmtree() failures.

The original code came in this commit:

revision 1.13
date: 2004/08/01 06:19:26; author: momjian; state: Exp; lines: +173 -7
Add docs for initdb --auth.

which obviouisly had an inaccurate description. I am not even sure
where the rmtree() code came from, but I think it was Andrew Dunstan.

Anyway, it never had errno checks with messages, so we didn't strip it
out; rather it was never there. The original code did a
system("rmdir") call so this code was obviously superior.

Anyway, I will apply the attached patch to CVS HEAD and 8.0.X in a day
or so.

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

Attachment Content-Type Size
unknown_filename text/plain 1.9 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2005-02-12 23:48:18 Re: [ADMIN] Migration of log features from 7.4 to 8.0
Previous Message Bruce Momjian 2005-02-12 10:44:27 Re: nls_sort function