ALTER TABLE ADD COLUMN exhibits a significant memory leak when adding a
column with a default expression. In that situation, we need to rewrite
the heap relation. To evaluate the new default expression, we use
ExecEvalExpr(); however, this can allocate memory in the current memory
context, and ATRewriteTable() does not switch out of the active portal's
heap memory context. The end result is a rather large memory leak (on
the order of gigabytes for a reasonably sized table).
This patch changes ATRewriteTable() to switch to the per-tuple memory
context before beginning the per-tuple loop. It also removes an explicit
heap_freetuple() in the loop, since that is no longer needed.
In an unrelated change, I noticed the code was scanning through the
attributes of the new tuple descriptor for each tuple of the old table.
I changed this to use precomputation, which should slightly speed up
Thanks to steve(at)deefs(dot)net for reporting the leak.
tablecmds.c (r1.145 -> r1.146)
pgsql-committers by date
|Next:||From: Neil Conway||Date: 2005-02-09 23:27:45|
|Subject: pgsql: ALTER TABLE ADD COLUMN exhibits a significant memory leak when |
|Previous:||From: Michael Meskes||Date: 2005-02-09 11:28:22|
|Subject: pgsql: Fixed bug in parsing of CREATE AS statement.|