Skip site navigation (1) Skip section navigation (2)

Re: libpq API incompatibility between 7.4 and 8.0

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>,PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>,Martin Pitt <mpitt(at)debian(dot)org>
Subject: Re: libpq API incompatibility between 7.4 and 8.0
Date: 2005-02-04 21:33:39
Message-ID: 200502042133.j14LXdT22567@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
> > Am Freitag, 4. Februar 2005 17:51 schrieb Bruce Momjian:
> >> I suggested to just get_progname() to libpq, not all of path.c.  The
> >> odds someone will depend on get_progname() in 8.0 are much less than the
> >> problems we will have as listed above.
> 
> > Perhaps a question is in order: Are we sure that get_progname() is the only 
> > problem, or just the first one the linker found?  Does anyone remember?
> 
> The report only showed that that one was the first the linker found.
> 
> The 7.4 libpq does include path.c in its entirety, meaning that there
> are potentially dependencies out there for all of the symbols defined by
> 7.4 path.c: is_absolute_path, first_path_separator, last_path_separator,
> in addition to get_progname.  In the 8.0 version of path.c these symbols
> are intertwined with a bunch more; what's more, is_absolute_path is now
> a macro not a routine, so we lost ABI compatibility anyway.  (I do in
> fact see is_absolute_path used in 7.4 psql; didn't bother looking for
> the others.)
> 
> In short, fixing this the way Bruce wants to will be a nontrivial amount
> of effort.

psql actually calls get_progname().  Do we know that it will try to link
in the other functions from path.c?  I am unsure.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-hackers by date

Next:From: Jim C. NasbyDate: 2005-02-04 21:35:59
Subject: Re: Escaping the ARC patent
Previous:From: TeddyDate: 2005-02-04 21:08:27
Subject: C++ Builder..

pgsql-patches by date

Next:From: Tom LaneDate: 2005-02-04 21:41:51
Subject: Re: libpq API incompatibility between 7.4 and 8.0
Previous:From: Tom LaneDate: 2005-02-04 18:48:47
Subject: Re: libpq API incompatibility between 7.4 and 8.0

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group