| From: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp> |
|---|---|
| To: | pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [PATCHES] WAL: O_DIRECT and multipage-writer (+ memory leak) |
| Date: | 2005-02-03 10:25:55 |
| Message-ID: | 20050203181338.9BDF.ITAGAKI.TAKAHIRO@lab.ntt.co.jp |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Hello everyone.
I fixed two bugs in the patch that I sent before.
Check and test new one, please.
1. Fix update timing of Write->curridx. (pointed by Tom)
Change to update it soon after write().
2. Fix buffer alignment routine on 64bit cpu. (pointed by Mark)
I checked it on Xeon EM64T and it worked properly, but I don't have IA64...
BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
(But this leak is not serious, because this function is called only once.)
ITAGAKI Takahiro
| Attachment | Content-Type | Size |
|---|---|---|
| xlog.c.diff | application/octet-stream | 12.5 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Mark Cave-Ayland | 2005-02-03 11:21:23 | Re: [NOVICE] Last ID Problem |
| Previous Message | Dawid Kuroczko | 2005-02-03 09:53:41 | Re: pg_dump bug in 7.3.9 with sequences |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2005-02-03 14:42:18 | Re: libpq API incompatibility between 7.4 and 8.0 |
| Previous Message | Peter Eisentraut | 2005-02-03 06:59:19 | Re: libpq API incompatibility between 7.4 and 8.0 |