Hello everyone.
I fixed two bugs in the patch that I sent before.
Check and test new one, please.
1. Fix update timing of Write->curridx. (pointed by Tom)
Change to update it soon after write().
2. Fix buffer alignment routine on 64bit cpu. (pointed by Mark)
I checked it on Xeon EM64T and it worked properly, but I don't have IA64...
BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
(But this leak is not serious, because this function is called only once.)
ITAGAKI Takahiro
Attachment: xlog.c.diff
Description: application/octet-stream (12.5 KB)
In response to
Responses
pgsql-hackers by date
| Next: | From: Mark Cave-Ayland | Date: 2005-02-03 11:21:23 |
| Subject: Re: [NOVICE] Last ID Problem |
| Previous: | From: Dawid Kuroczko | Date: 2005-02-03 09:53:41 |
| Subject: Re: pg_dump bug in 7.3.9 with sequences |
pgsql-patches by date
| Next: | From: Bruce Momjian | Date: 2005-02-03 14:42:18 |
| Subject: Re: libpq API incompatibility between 7.4 and 8.0 |
| Previous: | From: Peter Eisentraut | Date: 2005-02-03 06:59:19 |
| Subject: Re: libpq API incompatibility between 7.4 and 8.0 |