Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] WAL: O_DIRECT and multipage-writer (+ memory leak)

From: ITAGAKI Takahiro <itagaki(dot)takahiro(at)lab(dot)ntt(dot)co(dot)jp>
To: pgsql-hackers(at)postgresql(dot)org, pgsql-patches(at)postgresql(dot)org
Subject: Re: [PATCHES] WAL: O_DIRECT and multipage-writer (+ memory leak)
Date: 2005-02-03 10:25:55
Message-ID: 20050203181338.9BDF.ITAGAKI.TAKAHIRO@lab.ntt.co.jp (view raw or flat)
Thread:
Lists: pgsql-hackerspgsql-patches
Hello everyone.

I fixed two bugs in the patch that I sent before.
Check and test new one, please.

1. Fix update timing of Write->curridx. (pointed by Tom)
     Change to update it soon after write().

2. Fix buffer alignment routine on 64bit cpu. (pointed by Mark)
     I checked it on Xeon EM64T and it worked properly, but I don't have IA64...


BTW, I found memory leak in BootStrapXLOG(). The buffer allocated by malloc()
is not free()ed. ISSUE_BOOTSTRAP_MEMORYLEAK in this patch points out it.
(But this leak is not serious, because this function is called only once.)


ITAGAKI Takahiro

Attachment: xlog.c.diff
Description: application/octet-stream (12.5 KB)

In response to

Responses

pgsql-hackers by date

Next:From: Mark Cave-AylandDate: 2005-02-03 11:21:23
Subject: Re: [NOVICE] Last ID Problem
Previous:From: Dawid KuroczkoDate: 2005-02-03 09:53:41
Subject: Re: pg_dump bug in 7.3.9 with sequences

pgsql-patches by date

Next:From: Bruce MomjianDate: 2005-02-03 14:42:18
Subject: Re: libpq API incompatibility between 7.4 and 8.0
Previous:From: Peter EisentrautDate: 2005-02-03 06:59:19
Subject: Re: libpq API incompatibility between 7.4 and 8.0

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group