Re: dbsize patch

On Thursday January 27 2005 6:59, Andreas Pflug wrote:
> Neil Conway wrote:
> > On Tue, 2005-01-25 at 16:49 -0700, Ed L. wrote:
> >>The attached dbsize patch:
> >>
> >> + makes relation_size(relname) include toast tables;
> >> + adds aggregate_relation_size(relname) to count table data and
> >> indices; + adds indices_size(relname) to report the size of indices
> >> for a relation;
>
> Hm, these are all implementable as SQL functions, do we need these hard
> coded too?
>
> e.g.
> create function aggregate_relation_size(oid) returns int8 as $CODE$
> select sum(pg_relation_size(indexrelid)) from pg_index where indrelid=$1;
> $CODE$ language 'SQL'

Well, it seems quite a bit more complicated than that to me, but I'm going
to rework the patch so it drops into 7.3 as well and resubmit shortly.

Ed