Skip site navigation (1) Skip section navigation (2)

Re: sparse (static analyzer) report

From: Mark Wong <markw(at)osdl(dot)org>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>,pgsql-hackers(at)postgresql(dot)org
Subject: Re: sparse (static analyzer) report
Date: 2005-01-15 03:09:42
Message-ID: 20050114190942.A26611@osdl.org (view raw or flat)
Thread:
Lists: pgsql-hackers
Ah, so you beat me to it Neil. ;)  Out of curiosity, how much worse
was it before you started fixing things?

Mark

On Sat, Jan 15, 2005 at 01:30:37PM +1100, Neil Conway wrote:
> BTW, perhaps one reason for the relatively small number of legitimate 
> issues picked up by sparse is that I ran sparse on the tree a month or 
> two ago and fixed some of the stylistic issues it reported. Most of the 
> stuff I didn't bother to fix looked like either a sparse bug, or a 
> marginal style improvement I didn't bother applying (like fixing 0 => 
> NULL in dllist.c).
> 
> I've been meaning to investigate whether sparse can be used as something 
> more than just a fussy syntax checker (i.e. whether it can do any 
> meaningful static analysis for interesting properties), but I haven't 
> had a chance yet.
> 
> Alvaro Herrera wrote:
> > It's complaining in several places about function as variables in
> > function declarations (the multiple walkers and mutators for example);
> > not sure how correct that is.
> 
> I believe the conclusion of prior discussions about making the 
> walker/mutator prototypes more precise is that it's not worth the cost.
> 
> -Neil
> 
> P.S. Hope everyone had a good holiday. I'm back at work on Monday.



In response to

Responses

pgsql-hackers by date

Next:From: Dann CorbitDate: 2005-01-15 03:14:55
Subject: Re: PostgreSQL Specification
Previous:From: Neil ConwayDate: 2005-01-15 02:30:37
Subject: Re: sparse (static analyzer) report

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group