Re: LockObject patch

From: Alvaro Herrera <alvherre(at)dcc(dot)uchile(dot)cl>
To: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: LockObject patch
Date: 2004-12-20 20:55:44
Message-ID: 20041220205544.GB5287@dcc.uchile.cl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

On Mon, Dec 20, 2004 at 03:52:57PM -0500, Bruce Momjian wrote:

> When we roll over OID's do we make sure we never return InvalidOid?

Yes. From GetNewObjectId()

/*
* Check for wraparound of the OID counter. We *must* not return 0
* (InvalidOid); and as long as we have to check that, it seems a good
* idea to skip over everything below BootstrapObjectIdData too. (This
* basically just reduces the odds of OID collision right after a wrap
* occurs.) Note we are relying on unsigned comparison here.
*/

--
Alvaro Herrera (<alvherre[(at)]dcc(dot)uchile(dot)cl>)
"Es filósofo el que disfruta con los enigmas" (G. Coli)

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2004-12-21 00:22:30 Re: LockObject patch
Previous Message Bruce Momjian 2004-12-20 20:52:57 Re: LockObject patch