pgsql: Fix pg_dump to ensure that a comment on a table CHECK constraint

From: tgl(at)svr1(dot)postgresql(dot)org (Tom Lane)
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix pg_dump to ensure that a comment on a table CHECK constraint
Date: 2004-12-14 21:35:22
Message-ID: 20041214213522.A0DDA3AA761@svr1.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Log Message:
-----------
Fix pg_dump to ensure that a comment on a table CHECK constraint cannot
be emitted too soon. The previous code got this right in the case where
the CHECK was emitted as a separate ALTER TABLE command, but not in the
case where the CHECK is emitted right in CREATE TABLE. Per report from
Slawomir Sudnik.

Note: this code is pretty ugly; it'd perhaps be better to treat comments
as independently sortable dump objects. That'd be much too invasive a
change for RC time though.

Modified Files:
--------------
pgsql/src/bin/pg_dump:
pg_dump.c (r1.394 -> r1.395)
(http://developer.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_dump/pg_dump.c.diff?r1=1.394&r2=1.395)

Browse pgsql-committers by date

  From Date Subject
Next Message User K0cka 2004-12-14 21:46:40 press - pr: now for review
Previous Message Bruce Momjian 2004-12-14 14:53:54 pgsql: Update aix cc_r wording.