Skip site navigation (1) Skip section navigation (2)

Re: patch contrib/pgcrypto for win32 (2) - bug report

From: Marko Kreen <marko(at)l-t(dot)ee>
To: Korea PostgreSQL Users' Group <pgsql-kr(at)postgresql(dot)or(dot)kr>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: patch contrib/pgcrypto for win32 (2) - bug report
Date: 2004-12-06 19:20:45
Message-ID: 20041206192045.GA12778@l-t.ee (view raw or flat)
Thread:
Lists: pgsql-patches
On Tue, Dec 07, 2004 at 01:18:41AM +0900, Korea PostgreSQL Users' Group wrote:
> this bug is only for win32 system.
> 
> On mingw32 random() function have to be initialized by srandom().
> so, I put srandom(time(NULL)) line.
> and,
> Because random() function return integer (2byte), this return integer number need filtering.
> so, I changed random() % 255 line.
> 
> on win32, original code gen_salt() function allways returned "$1$/2E./2E.".
> this string made by same return value by random() function. (sorry, I can't express in good English)

This seems really suspicious.  My explanation would be, that
Win32 starup somehow skips the srandom call.

Or could the (MyProcPid ^ port->session_start.tv_usec) be
constant on win32?

> plz, check and properly fix this bug.
> 
> I tried "& 255" operation. but this bug is still.

I dont understand.  Does that mean that

	random()
	random() & 255

are buggy, but

	random() % 255

is not?

-- 
marko


In response to

pgsql-patches by date

Next:From: Peter EisentrautDate: 2004-12-06 22:10:40
Subject: Re: Translation updates for 8.0: pg_config-ru, initdb-ru, pg_ctl-ru, pg_dump-ru, psql-ru
Previous:From: Tom LaneDate: 2004-12-06 16:32:25
Subject: Re: patch contrib/pgcrypto for win32 (2) - bug report

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group