Skip site navigation (1) Skip section navigation (2)

Re: patch contrib/pgcrypto for win32 (2)

From: Marko Kreen <marko(at)l-t(dot)ee>
To: Korea PostgreSQL Users' Group <pgsql-kr(at)postgresql(dot)or(dot)kr>
Cc: pgsql-patches(at)postgresql(dot)org
Subject: Re: patch contrib/pgcrypto for win32 (2)
Date: 2004-12-05 23:27:27
Message-ID: 20041205232727.GA10439@l-t.ee (view raw or flat)
Thread:
Lists: pgsql-patches
On Mon, Dec 06, 2004 at 12:51:28AM +0900, Korea PostgreSQL Users' Group wrote:
> I found that function gen_salt() in contrib/pgcrypto had bug on win32.
> 
> I patched contrib/pgcrypto/random.c file.

Could you describe the bug bit more?

As for srandom, src/backend/postmaster/postmaster.c does it
already, and doing it more will make matters only worse.

I would not object to just sticking '& 255' there, but if
current code has problems then I imagine lot more code could be
affected.  Or are you just silencing some warning?

-- 
marko


In response to

Responses

pgsql-patches by date

Next:From: Tom LaneDate: 2004-12-05 23:36:38
Subject: Re: patch contrib/pgcrypto for win32 (2)
Previous:From: Tom LaneDate: 2004-12-05 22:42:10
Subject: Re: 8.0.0beta5 FailedAssertion (Crash) when casting composite types

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group