Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Code review for recent libpq changes.

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Michael Fuhr <mike(at)fuhr(dot)org>
Cc: Tom Lane <tgl(at)svr1(dot)postgresql(dot)org>,pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Code review for recent libpq changes.
Date: 2004-12-03 01:58:37
Message-ID: 200412030158.iB31wbg13973@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
OK, fixed.  Patch attached.  Thanks.

---------------------------------------------------------------------------

Michael Fuhr wrote:
> On Thu, Dec 02, 2004 at 11:20:24PM +0000, Tom Lane wrote:
> 
> > Code review for recent libpq changes.  Be more careful about error
> > handling in SIGPIPE processing; avoid unnecessary pollution of application
> > link-symbol namespace; spell 'pointer to function' in the conventional
> > way.
> 
> Build failure on FreeBSD 4.10-STABLE:
> 
> fe-secure.c: In function `pqsecure_write':
> fe-secure.c:433: `got_epipe' undeclared (first use in this function)
> 
> got_epipe is declared in an #ifdef ENABLE_THREAD_SAFETY block but
> then used outside of such a block.
> 
> -- 
> Michael Fuhr
> http://www.fuhr.org/~mfuhr/
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 6: Have you searched our list archives?
> 
>                http://archives.postgresql.org
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-12-03 01:58:44
Subject: pgsql: Fix compile breakage from SIGPIPE fix for threading.
Previous:From: Michael FuhrDate: 2004-12-03 01:53:29
Subject: Re: pgsql: Code review for recent libpq changes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group