Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Code review for recent libpq changes.

From: Michael Fuhr <mike(at)fuhr(dot)org>
To: Tom Lane <tgl(at)svr1(dot)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Code review for recent libpq changes.
Date: 2004-12-03 01:53:29
Message-ID: 20041203015329.GB5451@winnie.fuhr.org (view raw or flat)
Thread:
Lists: pgsql-committers
On Thu, Dec 02, 2004 at 11:20:24PM +0000, Tom Lane wrote:

> Code review for recent libpq changes.  Be more careful about error
> handling in SIGPIPE processing; avoid unnecessary pollution of application
> link-symbol namespace; spell 'pointer to function' in the conventional
> way.

Build failure on FreeBSD 4.10-STABLE:

fe-secure.c: In function `pqsecure_write':
fe-secure.c:433: `got_epipe' undeclared (first use in this function)

got_epipe is declared in an #ifdef ENABLE_THREAD_SAFETY block but
then used outside of such a block.

-- 
Michael Fuhr
http://www.fuhr.org/~mfuhr/

In response to

Responses

pgsql-committers by date

Next:From: Bruce MomjianDate: 2004-12-03 01:58:37
Subject: Re: pgsql: Code review for recent libpq changes.
Previous:From: Tom LaneDate: 2004-12-03 01:31:30
Subject: Re: pgsql: Fix for Unicode characters above 0x10000.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group