Skip site navigation (1) Skip section navigation (2)

Re: pgsql: Code review for recent libpq changes.

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)svr1(dot)postgresql(dot)org>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Code review for recent libpq changes.
Date: 2004-12-02 23:26:48
Message-ID: 200412022326.iB2NQma04474@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-committers
Nice.  You were able to get the EPIPE checks in there.

---------------------------------------------------------------------------

Tom Lane wrote:
> Log Message:
> -----------
> Code review for recent libpq changes.  Be more careful about error
> handling in SIGPIPE processing; avoid unnecessary pollution of application
> link-symbol namespace; spell 'pointer to function' in the conventional
> way.
> 
> Modified Files:
> --------------
>     pgsql/src/interfaces/libpq:
>         fe-connect.c (r1.291 -> r1.292)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-connect.c.diff?r1=1.291&r2=1.292)
>         fe-print.c (r1.56 -> r1.57)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-print.c.diff?r1=1.56&r2=1.57)
>         fe-secure.c (r1.58 -> r1.59)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/fe-secure.c.diff?r1=1.58&r2=1.59)
>         libpq-fe.h (r1.114 -> r1.115)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/libpq-fe.h.diff?r1=1.114&r2=1.115)
>         libpq-int.h (r1.97 -> r1.98)
>         (http://developer.postgresql.org/cvsweb.cgi/pgsql/src/interfaces/libpq/libpq-int.h.diff?r1=1.97&r2=1.98)
> 
> ---------------------------(end of broadcast)---------------------------
> TIP 9: the planner will ignore your desire to choose an index scan if your
>       joining column's datatypes do not match
> 

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

pgsql-committers by date

Next:From: Tom LaneDate: 2004-12-03 00:40:30
Subject: Re: pgsql: Fix for Unicode characters above 0x10000.
Previous:From: Tom LaneDate: 2004-12-02 23:20:24
Subject: pgsql: Code review for recent libpq changes.

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group