Re: statistics process shutting down

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Merlin Moncure <merlin(dot)moncure(at)rcsonline(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Win 32 hackers PGSQL <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: statistics process shutting down
Date: 2004-12-02 23:18:30
Message-ID: 200412022318.iB2NIUa28450@candle.pha.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers-win32


Is this an open item?

---------------------------------------------------------------------------

Merlin Moncure wrote:
>
> > > Maybe Magnus might comment here. This doesn't explain why the read
> call
> > > is failing but I'm pretty sure the error code is not being properly
> > > returned.
> >
> > I recall a lot of angst about whether the encoding of
> WSAGetLastError()
> > is compatible with errno values, but I forget what the conclusion was.
> > Can we just assign to errno like that, or do we need a mapping
> function?
>
> Ah. My bad.
> /backend/prot/win32/socket.c
>
> static void
> TranslateSocketError(void) etc. This puts the value in errno like it is
> suppoed to be. MS recv() does not (I checked) so this is definately a
> bug in pipe.c, since it is reasonable for the caller to expect errno to
> be set to something.
>
> Also, recv() and read() return completely different error codes :-). So
> any caller has to be careful not to make assumptions about errno.
>
> Merlin
>
> ---------------------------(end of broadcast)---------------------------
> TIP 2: you can get off all lists at once with the unregister command
> (send "unregister YourEmailAddressHere" to majordomo(at)postgresql(dot)org)
>

--
Bruce Momjian | http://candle.pha.pa.us
pgman(at)candle(dot)pha(dot)pa(dot)us | (610) 359-1001
+ If your life is a hard drive, | 13 Roberts Road
+ Christ can be your backup. | Newtown Square, Pennsylvania 19073

In response to

Browse pgsql-hackers-win32 by date

  From Date Subject
Next Message Claudio Natoli 2004-12-03 01:59:20 Re: [PERFORM] scalability issues on win32
Previous Message Bruce Momjian 2004-12-02 22:48:02 Re: [BUGS] pg_autovacuum in 8beta-dev3 small bug