Skip site navigation (1) Skip section navigation (2)

Re: [PATCHES] psql \! WIN32 cleanup

From: Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>,PostgreSQL Win32 port list <pgsql-hackers-win32(at)postgresql(dot)org>
Subject: Re: [PATCHES] psql \! WIN32 cleanup
Date: 2004-11-06 05:49:56
Message-ID: 200411060549.iA65nuo29918@candle.pha.pa.us (view raw or flat)
Thread:
Lists: pgsql-hackers-win32pgsql-patches
Tom Lane wrote:
> Bruce Momjian <pgman(at)candle(dot)pha(dot)pa(dot)us> writes:
> > The attached applied patch tests for COMSPEC in the right place and
> > supplies a reasonable shell default on Win32.
> 
> > + #define DEFAULT_SHELL "c:/windows/system32/cmd.exe"
> 
> Is it really a good idea to assume that the Windows installation is on
> drive C: ?
> 
> (This is an honest question, not a rhetorical one.  I dunno whether
> inserting the C: is better than leaving it off.  I can think of cases
> where either way will break, but I'm unsure what's most likely in
> practice.)

Not sure.  Should we just do "/windows/system32/cmd.exe" and leave off
the C:?  The previous default was "/bin/sh" and that certainly will not
work on Win32.

-- 
  Bruce Momjian                        |  http://candle.pha.pa.us
  pgman(at)candle(dot)pha(dot)pa(dot)us               |  (610) 359-1001
  +  If your life is a hard drive,     |  13 Roberts Road
  +  Christ can be your backup.        |  Newtown Square, Pennsylvania 19073

In response to

Responses

pgsql-patches by date

Next:From: Bruce MomjianDate: 2004-11-06 05:56:24
Subject: Re: ON COMMIT and foreign keys
Previous:From: Tom LaneDate: 2004-11-06 05:43:51
Subject: Re: ON COMMIT and foreign keys

pgsql-hackers-win32 by date

Next:From: John A MeinelDate: 2004-11-06 06:10:49
Subject: Re: [PATCHES] psql \! WIN32 cleanup
Previous:From: Tom LaneDate: 2004-11-06 05:30:55
Subject: Re: psql \! WIN32 cleanup

Privacy Policy | About PostgreSQL
Copyright © 1996-2014 The PostgreSQL Global Development Group